Add terminationGracePeriodSeconds support to user and sidecar container probes (#15823) #16255

flomedja · 2025-11-21T20:36:43Z

Fixes #

Proposed Changes

Add terminationGracePeriodSeconds in the probe Mask used for the container probes. This will allw it to be configurable for the container probes. I add the issue #16256 to validate the the startup probes for user and sidecar containers.

Release Note

Add  `terminationGracePeriodSeconds` support for user and sidecar container probes

knative-prow · 2025-11-21T20:36:53Z

Hi @flomedja. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-11-21T20:42:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.06%. Comparing base (6d9d1b6) to head (3ee3f3a).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16255      +/-   ##
==========================================
- Coverage   80.09%   80.06%   -0.03%     
==========================================
  Files         215      215              
  Lines       13361    13362       +1     
==========================================
- Hits        10701    10698       -3     
- Misses       2300     2304       +4     
  Partials      360      360

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flomedja · 2025-11-21T22:01:15Z

@dsimansk @skonto Can you help to rerun the failed e2e test ?

linkvt · 2025-11-22T01:04:59Z

/retest

linkvt · 2025-11-22T01:11:24Z

/ok-to-test

flomedja · 2025-11-27T03:34:12Z

@dsimansk @skonto just a little reminder for the review :)

dprotaso · 2025-12-04T17:12:32Z

pkg/apis/serving/k8s_validation_test.go

-				ProbeHandler: corev1.ProbeHandler{
-					HTTPGet: &corev1.HTTPGetAction{
-						Path: "/",
+	tests := []containerValidationTestCase{


Can we revert the formatting to how it was - it will make the diff simpler

@dprotaso it's done :)

…er probes (knative#15823)

dprotaso · 2025-12-17T21:55:36Z

/retest

dprotaso · 2025-12-17T21:56:15Z

/lgtm
/approve

thanks for the change

knative-prow · 2025-12-17T21:56:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, flomedja

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/apis/OWNERS~~ [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso · 2025-12-17T22:08:54Z

/retest

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2025

knative-prow bot requested review from dsimansk and skonto November 21, 2025 20:36

flomedja force-pushed the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch from 07930a5 to ebeeacb Compare November 21, 2025 21:05

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2025

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2025

dprotaso reviewed Dec 4, 2025

View reviewed changes

flomedja force-pushed the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch from ebeeacb to 403a8ad Compare December 11, 2025 22:59

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2025

flomedja force-pushed the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch from 403a8ad to ca88913 Compare December 11, 2025 23:26

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025

flomedja force-pushed the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch from ca88913 to f4bb5a1 Compare December 11, 2025 23:33

Add terminationGracePeriodSeconds support to user and sidecar contain…

3ee3f3a

…er probes (knative#15823)

flomedja force-pushed the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch from f4bb5a1 to 3ee3f3a Compare December 11, 2025 23:45

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2025

knative-prow bot assigned dprotaso Dec 17, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025

knative-prow bot merged commit 343df7e into knative:main Dec 18, 2025
281 of 284 checks passed

flomedja deleted the 15823-add-terminationgraceperiodseconds-for-containers-and-sidecar-containers-liveness-probes branch January 10, 2026 12:05

Add terminationGracePeriodSeconds support to user and sidecar container probes (#15823) #16255

Add terminationGracePeriodSeconds support to user and sidecar container probes (#15823) #16255

Uh oh!

Conversation

flomedja commented Nov 21, 2025 • edited by dprotaso Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

knative-prow bot commented Nov 21, 2025

Uh oh!

codecov bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

flomedja commented Nov 21, 2025

Uh oh!

linkvt commented Nov 22, 2025

Uh oh!

linkvt commented Nov 22, 2025

Uh oh!

flomedja commented Nov 27, 2025

Uh oh!

dprotaso Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

flomedja Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dprotaso commented Dec 17, 2025

Uh oh!

dprotaso commented Dec 17, 2025

Uh oh!

knative-prow bot commented Dec 17, 2025

Uh oh!

dprotaso commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

flomedja commented Nov 21, 2025 •

edited by dprotaso

Loading

codecov bot commented Nov 21, 2025 •

edited

Loading